Add Typescript type definitions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisMBarr Cool! Is it ok if I rename to Thanks for contributing! |
|
Sure, that should be fine to do.
… On Feb 8, 2017, at 6:28 PM, Ryan Van Etten ***@***.***> wrote:
@ChrisMBarr Cool! Is it ok if I rename to eol.d.ts to match the main file? Does that make sense?
"main": "eol.js",
"types": "eol.d.ts",
"typings": "eol.d.ts",
Thanks for contributing!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Available in 0.6.0 Happy eol'ing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written some TypeScript type definitions for this project, and this PR will include them in the distribution and allow either typings or @types in TypeScript 2.x to automatically pick them up.