Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(install): Add PowerShell Web Installer #1701

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

jpawlowski
Copy link
Contributor

Description

This will add some information about an alternative installation method for PowerShell.
Also see discussion here: #1697

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

Update README.md with info about PowerShell web install option.

How should this be manually tested?

n/a

Any background context you can provide?

n/a

What are the relevant tickets (if any)?

#1697

Screenshots (if appropriate or helpful)

PowerShell Nerd Fonts Installer

@jpawlowski
Copy link
Contributor Author

@all-contributors please add @jpawlowski for doc

Copy link
Contributor

@jpawlowski

I've put up a pull request to add @jpawlowski! 🎉

PS Gallery doesn't like the trailing slash
@jpawlowski jpawlowski changed the title doc(install): Add PowerShell Web Installer docs(install): Add PowerShell Web Installer Sep 1, 2024
Copy link
Collaborator

@Finii Finii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thank you!

I guess pwsh is nowadays called powershell? I never used powershell I have no clue 😬 (I can hardly believe it is not executed via pwsh on linuxerian OSes).

And this certainly renders it useless , 2404 is ages old already. Whatever, that does not matter for this PR.

Screenshot 2024-09-01 at 16 13 57

readme.md Outdated Show resolved Hide resolved
@Finii
Copy link
Collaborator

Finii commented Sep 1, 2024

Hmm, not supporting Ubuntu 24.04 makes no sense.
And/but they support MacOS 14.6.1 (latest latest) via Homebrew? This is strange, why is it not community-supported on Ubuntu?

fini@Air scripts % uname -a
Darwin Air 23.6.0 Darwin Kernel Version 23.6.0: Mon Jul 29 21:16:46 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T8112 arm64
fini@Air scripts % brew info powershell
==> powershell: 7.4.2
https://github.com/PowerShell/PowerShell
Not installed
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/p/powershell.rb
==> Name
PowerShell
==> Description
Command-line shell and scripting language
==> Artifacts
powershell-7.4.2-osx-arm64.pkg (Pkg)
==> Caveats
To use Homebrew in PowerShell, run the following in a PowerShell session:
  New-Item -Path (Split-Path -Parent -Path $PROFILE.CurrentUserAllHosts) -ItemType Directory -Force
  Add-Content -Path $PROFILE.CurrentUserAllHosts -Value '$(/opt/homebrew/bin/brew shellenv) | Invoke-Expression'

==> Analytics
install: 11,523 (30 days), 37,265 (90 days), 102,246 (365 days)
fini@Air scripts %

@Finii
Copy link
Collaborator

Finii commented Sep 1, 2024

Hmm, in comparsion the new install method takes quite a lot of space; maybe hide some of the sub-points by just linking to the documentation on your installers project and list only the one or two major things explicitly.

@jpawlowski
Copy link
Contributor Author

jpawlowski commented Sep 2, 2024

I guess pwsh is nowadays called powershell? I never used powershell I have no clue 😬 (I can hardly believe it is not executed via pwsh on linuxerian OSes).

Indeed, PowerShell 7 was initially known as "PowerShell Core" following its complete overhaul in version 6. It's distinct from Windows PowerShell 5.1, which is reflected in its binary file name pwsh.exe for Windows, allowing it to run alongside the older version. Similarly, Unix systems use the pwsh name for their binaries.

Despite these changes, for backward compatibility, documentation and markdown language tags often simply refer to it as powershell. For instance, the Microsoft documentation on including code adheres to this convention. GitHub's syntax highlighter, powered by linguist, recognizes pwsh as a synonym for powershell, which might have led to the oversight in updating your documentation. Apologies for any confusion caused.

And this certainly renders it useless , 2404 is ages old already. Whatever, that does not matter for this PR.
...
Hmm, not supporting Ubuntu 24.04 makes no sense. And/but they support MacOS 14.6.1 (latest latest) via Homebrew? This is strange, why is it not community-supported on Ubuntu?

Regarding Ubuntu releases, the designation of the latest LTS version is finalized with the first .1 point release, which happened on August 29th, 2024. Firms like Microsoft usually await this milestone before incorporating the new LTS version into their lineup of supported OS. Technically, Microsoft has prepared much of the necessary infrastructure. I've also pitched in with a small update for the Dev Container features, so we can expect full support to roll out soon. :-)

It's worth noting that the term "supported" doesn't imply any malfunction; it simply refers to the availability of commercial support, such as contacting Microsoft for assistance when something doesn't work as anticipated. I know in German we usually think about "etwas wird unterstützt" a little differently, like "läuft nicht".

Hmm, in comparsion the new install method takes quite a lot of space; maybe hide some of the sub-points by just linking to the documentation on your installers project and list only the one or two major things explicitly.

I've taken this into account in the latest update. Could you please review it again?

@Finii Finii merged commit 384b182 into ryanoasis:master Sep 5, 2024
@Finii
Copy link
Collaborator

Finii commented Sep 5, 2024

Thanks again 👍 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants