Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/fix octa scale #1199

Merged
merged 2 commits into from
May 3, 2023
Merged

Bugfix/fix octa scale #1199

merged 2 commits into from
May 3, 2023

Commits on May 3, 2023

  1. font-patcher: Fix some Octicons scales 

    [why]
With the Octicons update some codepoint contents changed.
Also some symbols scale still wrong.

[how]
Check fonts and add / drop entries.
Use GlyphsToScale+ to correct position of Github text icon.

Fixes: #1198

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    @Finii
    Finii committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ae6eff0 View commit details
    Browse the repository at this point in the history

  2. font-patcher: Modernize and expand Octicons scale table 

    [why]
The scale glyph is not the biggest glyph; the bell-slash is a little bit
wider than the design cell...

[how]
Switch to modern ScaleGroups. These determine the virtual combined
bounding box of all glyphs in the group and scale them 'as one'.

Also add some more groups.

Also correct wrong code of one small stuff.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
    @Finii
    Finii committed May 3, 2023
    Configuration menu
    Copy the full SHA
    ef67e02 View commit details
    Browse the repository at this point in the history