Allow auto original source growth #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] There is a bit of code that is not needed anymore (or was never needed). This makes things look more complicated than they are. [how] 1. It is plain wrong to write that we add one (1) glyph if we do not add any glyph. 2. One (1) is added to index later anyhow, so we do not need to distort the counting in the beginning (the code will run with index=1 for both the first and the second patched in glyph). Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
[why] We have an automation for adding glyphs to the original set. If someone throws in the svg file and adds the glyph to the icons.tsv a new original-source font is generated. But the added glyphs are not patched in, because that would need a change at font-patcher (adjust the end codepoint). This can be forgotten easily. [how] The maximum codepoint of our own (original + seti) set is 0xE6FF. At 0xE700 the Devicons start. The original-source generation script now checks the offset, they may not be negative and on the positive end we may not leave our set-range. If that happens the script fails thus the workflow fails. Also increate the patch range in font-patcher. If there are no icons to patch in the symbol font the codepoints are just ignored. [note] See also PR #1119 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
force-pushed
the
feature/original-source-growth
branch
from
00c805d
to
836cc13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow for growing original icon set
[why]
We have an automation for adding glyphs to the original set.
If someone throws in the svg file and adds the glyph to the icons.tsv a
new original-source font is generated.
But the added glyphs are not patched in, because that would need a
change at font-patcher (adjust the end codepoint).
This can be forgotten easily.
[how]
The maximum codepoint of our own (original + seti) set is 0xE6FF. At
0xE700 the Devicons start.
The original-source generation script now checks the offset, they may
not be negative and on the positive end we may not leave our set-range.
If that happens the script fails thus the workflow fails.
Also increate the patch range in font-patcher. If there are no icons to
patch in the symbol font the codepoints are just ignored.
[note]
See also PR #1119
This PR also smuggles in a small unrelated code cleanup commit.
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)