Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update Octicons to latest #490

Closed
4 tasks done
jef opened this issue Jun 16, 2020 · 9 comments · Fixed by #1156
Closed
4 tasks done

feat: update Octicons to latest #490

jef opened this issue Jun 16, 2020 · 9 comments · Fixed by #1156
Labels
{ ; } update glyph set
Milestone
v3.0.0

Comments

@jef
Copy link

jef commented Jun 16, 2020

🗹 Requirements

  • A brief but descriptive title of your issue
  • I have searched the issues for my issue and found nothing related and/or helpful
  • I have read or scanned the FAQ
  • I have read or scanned the Wiki

🎯 Subject of the issue

Update the Octicons to 10.0.0. Released on 06/10/2020.

★ Optional

Link to new Octicons: https://primer.style/octicons/
@ryanoasis ryanoasis added this to the v3.0.0 milestone Dec 14, 2021
@jef jef changed the title feat: update Octicons to 10.0.0 feat: update Octicons to 10.0.0 (or latest) Jan 23, 2023
@jef jef changed the title feat: update Octicons to 10.0.0 (or latest) feat: update Octicons to latest Jan 23, 2023
@djensenius
Copy link

Any update on this?

@Finii
Copy link
Collaborator

Finii commented Mar 24, 2023

@djensenius This has a v3.0.0 tag. That release is due ... some days ago.

See #1074. Updated all source fonts, only some few issues open, this is one of them. Hope to finish this month.

@djensenius
Copy link

Awesome! Thanks @Finii !

@Finii
Copy link
Collaborator

Finii commented Mar 24, 2023

Hmm, there seems to be no updated opticons font anymore in the original repo.
At least according to Arch, who build the font on their own from the svgs:

image

https://aur.archlinux.org/packages/ttf-octicons

They use fantasticon, but that breaks the codepoint stability, or not? Checking.
That would mean we need to self-create that font.
Do you have any information on this @djensenius ? Tnx.

@Finii
Copy link
Collaborator

Finii commented Mar 24, 2023

Hmm, the produced font has completely different codepoints / sorting, this is not useful... :-(

image

@Finii
Copy link
Collaborator

Finii commented Mar 24, 2023

The mapping here https://github.com/microsoft/vscode-octicons-font seems to be the old one / the one we use.
We can use that to resurrect and update the font generation with current svgs.

@Finii
Copy link
Collaborator

Finii commented Mar 25, 2023 •
edited
Loading

At the moment the octicons are at F400 with length 105 which after gap removal turns into end codepoint F4A9.
Currently at F500 Material Design starts...:

image

In Octicons 18.2.0 there are 107 icons, making the new end F507, which just penetrates a little bit into old MDI territory.

@Finii
Copy link
Collaborator

Finii commented Mar 25, 2023 •
edited
Loading 

Reading mapping file
Found 172 entries
Fetching octicons archive "v18.2.0.tar.gz"
Unpacking octicons archive
Found 574 svgs
Found 308 icons after de-duplicating

Renamed cloud-download -> download
Renamed cloud-upload -> upload
Renamed clippy -> paste
Renamed mail-read -> read
Renamed primitive-dot -> dot-fill
Renamed primitive-square -> square-fill
Renamed settings -> sliders
Renamed dashboard -> meter
Renamed trashcan -> trash
Renamed paintcan -> paintbrush

Missing octoface
Missing keyboard
Missing gist
Missing file-text
Missing file-pdf
Missing jersey
Missing radio-tower
Missing repo-force-push
Missing mail-reply
Missing arrow-small-right
Missing gist-secret
Missing no-newline
Missing arrow-small-up
Missing arrow-small-down
Missing arrow-small-left
Missing file-symlink-directory
Missing circuit-board
Missing watch
Missing text-size
Missing ellipses
Missing plus-small

Found 151 (of 172, missing 21) and new 157

Finii added a commit that referenced this issue Mar 25, 2023
@Finii
Create new octicons.ttf
6dc35a2 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii Finii mentioned this issue Mar 25, 2023
Merged
2 tasks
Finii added a commit that referenced this issue Mar 25, 2023
@Finii
Create new octicons.ttf
8cbb6de 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Mar 26, 2023
@Finii
Create new octicons.ttf (1/2)
63e6ea6 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

This commit just moves all the mechanics in and moves the (old) font.
No actual update here.

The mapping file has been created with the analyze_octicons script.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Mar 26, 2023
@Finii
Create new octicons.ttf (1/3)
213e88e 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

This commit just moves all the mechanics in and moves the (old) font.
No actual update here.

The mapping file has been created with the analyze_octicons script.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Mar 26, 2023
@Finii
Create new octicons.ttf (1/2)
673cf75 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

This commit just moves all the mechanics in and moves the (old) font.
No actual update here.

The mapping file has been created with the analyze_octicons script.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Mar 26, 2023
@Finii
Create new octicons.ttf (1/2)
c8fa239 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

This commit just moves all the mechanics in and moves the (old) font.
No actual update here.

The mapping file has been created with the analyze_octicons script.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Apr 24, 2023
@Finii
Create new octicons.ttf (1/2)
e19d6b3 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

This commit just moves all the mechanics in and moves the (old) font.
No actual update here.

The mapping file has been created with the analyze_octicons script.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii added a commit that referenced this issue Apr 24, 2023
@Finii
Create new octicons.ttf (1/2)
91953e2 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

This commit just moves all the mechanics in and moves the (old) font.
No actual update here.

The mapping file has been created with the analyze_octicons script.

Fixes: #490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
LNKLEO pushed a commit to LNKLEO/Nerd that referenced this issue Nov 24, 2023
@Finii
Create new octicons.ttf (1/2)
947c578 
[why]
The octicons got a lot updates.
But they do not have a font anymore.

[how]
Keep our old codepoints constant, but add the new icons thereafter.

This commit just moves all the mechanics in and moves the (old) font.
No actual update here.

The mapping file has been created with the analyze_octicons script.

Fixes: ryanoasis#490

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
{ ; } update glyph set
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

Update octicons and drop old MDI ryanoasis/nerd-fonts
4 participants
@djensenius @ryanoasis @jef @Finii