DejaVu has no Regular with Putty #1249
Labels
Comments
|
Hmm, did we not prevent this?
Edit: Ugg, that is the source font, not the patched font...
|
|
Font is patched with $ find . -name '*.ttf' -and -name '*Mono-*' -print -exec bash -c 'ttfdump {} | grep fsS' \;
./Regular/DejaVuSansMNerdFontMono-Regular.ttf
fsSelection: 0x01c0 'Regular '
./Bold/DejaVuSansMNerdFontMono-Bold.ttf
fsSelection: 0x01a0 'Bold '
./Italic/DejaVuSansMNerdFontMono-Oblique.ttf
fsSelection: 0x0380 ''
./Bold-Italic/DejaVuSansMNerdFontMono-BoldOblique.ttf
fsSelection: 0x03a0 'Bold ' |
Finii
added a commit
that referenced
this issue
May 22, 2023
[why] For fonts that have no Italic but an Oblique - i.e. when Oblique shall replace the Italic role in RIBBI font grouping (classic group of 4) - that grouping fails. This affects DejaVu on Putty. [how] For RIBBI grouping only the classic bits are considered. That means that for fonts that have Oblique instead of Italic (and not additionally) we need to set the ITALIC bit and the OBLIQUE bit. This has been overlooked. Cite from the specs: > This bit, unlike the ITALIC bit (bit 0), is not related to style-linking > in applications that assume a four-member font-family model comprised > of regular, italic, bold and bold italic. It may be set or unset > independently of the ITALIC bit. In most cases, if OBLIQUE is set, then > ITALIC will also be set, though this is not required. Fixes: #1249 Reported-by: Huifeng Shen <liaoya@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
2 tasks
Finii
added a commit
that referenced
this issue
May 22, 2023
[why] For fonts that have no Italic but an Oblique - i.e. when Oblique shall replace the Italic role in RIBBI font grouping (classic group of 4) - that grouping fails. This affects DejaVu on Putty. [how] For RIBBI grouping only the classic bits are considered. That means that for fonts that have Oblique instead of Italic (and not additionally) we need to set the ITALIC bit and the OBLIQUE bit. This has been overlooked. Cite from the specs: > This bit, unlike the ITALIC bit (bit 0), is not related to style-linking > in applications that assume a four-member font-family model comprised > of regular, italic, bold and bold italic. It may be set or unset > independently of the ITALIC bit. In most cases, if OBLIQUE is set, then > ITALIC will also be set, though this is not required. [note] Also increase font-patcher version. Fixes: #1249 Reported-by: Huifeng Shen <liaoya@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Finii
added a commit
that referenced
this issue
May 22, 2023
[why] For fonts that have no Italic but an Oblique - i.e. when Oblique shall replace the Italic role in RIBBI font grouping (classic group of 4) - that grouping fails. This affects DejaVu on Putty. [how] For RIBBI grouping only the classic bits are considered. That means that for fonts that have Oblique instead of Italic (and not additionally) we need to set the ITALIC bit and the OBLIQUE bit. This has been overlooked. Cite from the specs: > This bit, unlike the ITALIC bit (bit 0), is not related to style-linking > in applications that assume a four-member font-family model comprised > of regular, italic, bold and bold italic. It may be set or unset > independently of the ITALIC bit. In most cases, if OBLIQUE is set, then > ITALIC will also be set, though this is not required. [note] Also increase font-patcher version. Fixes: #1249 Reported-by: Huifeng Shen <liaoya@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this issue
Nov 24, 2023
[why] For fonts that have no Italic but an Oblique - i.e. when Oblique shall replace the Italic role in RIBBI font grouping (classic group of 4) - that grouping fails. This affects DejaVu on Putty. [how] For RIBBI grouping only the classic bits are considered. That means that for fonts that have Oblique instead of Italic (and not additionally) we need to set the ITALIC bit and the OBLIQUE bit. This has been overlooked. Cite from the specs: > This bit, unlike the ITALIC bit (bit 0), is not related to style-linking > in applications that assume a four-member font-family model comprised > of regular, italic, bold and bold italic. It may be set or unset > independently of the ITALIC bit. In most cases, if OBLIQUE is set, then > ITALIC will also be set, though this is not required. [note] Also increase font-patcher version. Fixes: ryanoasis#1249 Reported-by: Huifeng Shen <liaoya@gmail.com> Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
🗹 Requirements
This issue was originally raised by liaoya (Huifeng Shen) on Gitter. Thank you.
🎯 Subject of the issue
Experienced behavior:
Putty shows only Oblique, Bold Oblique and Bold for
DejaVuSansM Nerd Font MonoAlso Bold Oblique is depicted as Bold
Expected behavior:
Example symbols:
🔧 Your Setup
Anonymice Powerline Nerd Font Complete.ttf)?DejaVuSansM Nerd Font Monoiterm2,urxvt,gnome,konsole)?★ Screenshots (Optional)
The text was updated successfully, but these errors were encountered: