Make base glob configurable via coverageBaseDir #271
Conversation
There was a problem hiding this comment.
Looking great, I would add a few tests (unit or integration, I can also help a bit next weekend if you are having trouble adding them but there should be quite a few examples to go off of 🤔 ) and maybe a few documentation comments but otherwise I think this is a good addition, thanks again!
|
Converted to draft. #270 should go in first |
…fully-configurable-glob
…fully-configurable-glob
|
@ryanluker this PR is ready for review |
|
@ryanluker Do you have any updates on the 2.6.0 release date? |
|
@amatosov-rbx I was hoping the last item from the milestone would get in but if it isn't by Sunday I will just go away with a release. https://github.com/ryanluker/vscode-coverage-gutters/milestone/31 |
|
@amatosov-rbx 2.6.0 should be out now! thanks again for the effort in adding / fixing this 😁 . |
|
@ryanluker Thanks for getting the release out and quick feedback on fixes and additions =) |
Rational
On big workspaces (e.g. 12k directories, 74k files) recursive glob lookup
**is very time consuming. Currently there is no way to avoid it via configuration options.manualCoverageFilePathsis the only option, however it eliminates any kind of glob lookup, which is not desired.Change
Introduce
coverageBaseDirthat allows users to fully customize lookup glob for coverage filesIt defaults to
**, so existing behavior is not going to change.