Support skip forward backward in command center (iOS). #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Hi @addie9000 I've accepted @DGempler 's issue mentioned above which may affect yours. Please try the latest on master and let me know if you have any thoughts pertaining to your use case. |
|
Hi @ryanheise, @DGempler's issue you merged is definitely fix the bug in my previous PR. I tried the master and confirm the bug is fixed. I also pretty sure it fixes #295 also. Thank you @ryanheise and @DGempler ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables iOS skip forward and backward control in command center.
Because iOS's skip forward and backward buttons in command center need interval time (seconds) to display, add some start parameter.
If set zero or negative for the interval values, skip forward and/or backward buttons are disabled independently.