Custom notification button drawables are tree-shaken by default

[nuc134r]

After recent Flutter 1.12 update building release APK with flutter build apk started to shrink unused resources. It might as well be something I missed during migration to the new Flutter version but it was quite painful to figure out.

:android:shrinkDebugResources
Removed unused resources: Binary resource data reduced from 2570KB to 1711KB: Removed 33%

As I was using custom icons for notification buttons and they were not referenced anywhere except Dart code it made them disappear from release apk.

MediaControl playControl = MediaControl(
  androidIcon: 'drawable/ic_action_play_arrow',
  label: 'Play',
  action: MediaAction.play,
);

I suggest documenting that somewhere in code or README.

In my case adding shrinkResources false into build.gradle solved the problem.

buildTypes {
    release {
        signingConfig signingConfigs.debug
        shrinkResources false
    }
}

[nuc134r]

By the way thank you for this beautiful library. You write such detailed and wholesome comments in issues explaining and solving user problems that it makes me proud of GitHub community. Just by reading some of your comments in issues I solved almost all my problems with this library. Also discussions about bi-directional custom actions make me think that soon I won't need to keep a fork of audio_service. You rock, Ryan.

My son recently said that he wants to be Ryan Heise when he grows up. And I hope so.

[ryanheise]

@nuc134r Thank you for investigating and figuring out the fix! (And also for the kind words :-) )

I'd like to test this myself although I may need to fix #136 first which is preventing release builds, so I will leave this issue open until then.

[ryanheise]

I've managed to test your fix now and can confirm it works. Thanks! I've updated the README file accordingly.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs, or use StackOverflow if you need help with audio_service.