Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace redundant config with filament plugin method #86

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Replace redundant config with filament plugin method #86

merged 2 commits into from
Aug 7, 2023

Conversation

howdu
Copy link
Contributor

@howdu howdu commented Aug 7, 2023

No description provided.

ryangjchandler
ryangjchandler requested changes Aug 7, 2023
View reviewed changes
Copy link
Owner

@ryangjchandler ryangjchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can actually use FilamentNavigation::get() instead of the filament('navigation') etc.

@howdu howdu requested a review from ryangjchandler August 7, 2023 15:29
@ryangjchandler
Copy link
Owner

Ignore the failing tests for now!

@ryangjchandler ryangjchandler merged commit c9045e2 into ryangjchandler:main Aug 7, 2023
@howdu howdu deleted the fix-redundant-config branch August 7, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryangjchandler ryangjchandler Awaiting requested review from ryangjchandler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howdu @ryangjchandler