Add default value of 1 to decrement to match increment

ryanalane · Nov 5, 2013 · c4b3857 · c4b3857
1 parent cfbec56
commit c4b3857
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/lib/dao.js b/lib/dao.js
@@ -391,6 +391,10 @@ module.exports = (function() {
       });
     }
 
+    if (count === undefined) {
+      count = 1;
+    }
+
     return this.increment(fields, 0 - count);
   }
 

diff --git a/test/dao.test.js b/test/dao.test.js
@@ -290,6 +290,18 @@ describe(Support.getTestDialectTeaser("DAO"), function () {
       })
     })
 
+    it('with single field and no value', function(done) {
+      var self = this
+      this.User.find(1).complete(function(err, user1) {
+        user1.increment('aNumber').complete(function() {
+          self.User.find(1).complete(function(err, user2) {
+            expect(user2.aNumber).to.be.equal(1)
+            done()
+          })
+        })
+      })
+    })
+
     it('should still work right with other concurrent updates', function(done) {
       var self = this
       this.User.find(1).complete(function (err, user1) {
@@ -388,6 +400,18 @@ describe(Support.getTestDialectTeaser("DAO"), function () {
       })
     })
 
+    it('with single field and no value', function(done) {
+      var self = this
+      this.User.find(1).complete(function(err, user1) {
+        user1.decrement('aNumber').complete(function() {
+          self.User.find(1).complete(function(err, user2) {
+            expect(user2.aNumber).to.be.equal(-1)
+            done()
+          })
+        })
+      })
+    })
+
     it('should still work right with other concurrent updates', function(done) {
       var self = this
       this.User.find(1).complete(function(err, user1) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -391,6 +391,10 @@ module.exports = (function() { @@
           });
         }
+        if (count === undefined) {
+          count = 1;
+        }
         return this.increment(fields, 0 - count);
       }
@@ Expand Down @@