Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test manifest to work in current chrome ver #9

Closed
wants to merge 1 commit into from

Conversation

maks
Copy link

@maks maks commented Mar 26, 2014

While this get the tests running in the current chrome, I can't actually get them to pass, with an error which I think is from test 9:

success api-built.js:981
GET https://github.com/maks/gittest1.git/info/refs?service=git-receive-pack 401 (Authorization Required) github.com/maks/gittest1.git/info/refs?service=git-receive-pack:1
Object {type: 201, msg: "Http authentication failed", auth: "Basic realm="GitHub""} api-built.js:975
error api-built.js:975
(anonymous function) api-built.js:986
worker.onmessage api-built.js:1005

@maks
Copy link
Author

maks commented Mar 26, 2014

Sorry @ryanackley should also add that I was testing using the repo: https://github.com/maks/gittest1 so I'm not sure if the tests are only supposed to pass if you run your own local http server, serving a local repo with particular files/commits in it?

@ryanackley
Copy link
Owner

My version just worked for me against a Github repo in the latest version of Chrome. Did you try loading it as an unpacked extension before you made the manifest changes? I just did that and it loaded fine in the latest Chrome and all tests pass.

You upgraded the manifest to the latest "packaged app". The problem is that this type of Chrome extension doesn't support the Basic Auth login dialog. This is required to run the tests.

This is the problem you're having. There is no way to login to the server you're trying to access.

@maks
Copy link
Author

maks commented Mar 27, 2014

Yes sorry about that @ryanackley that was exactly it! I thought I needed to convert it over because there was no "Launch" link in the chrome://extensions entry, I completely forgot to actually look in chrome://apps for its launcher icon.
Now that I've got that running, I'll get onto actually getting tests done for the changes in my previous PRs.

@maks maks closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants