Load balance the test file timings across N workers instead of applying a bin packing algorithm #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a bin packing algorithm
tonywok
previously approved these changes
Apr 21, 2025
| @@ -24,6 +23,5 @@ func (p TestPartition) AddFilePath(filepath string) TestPartition { | |||
| } | |||
|
|
|||
| func (p TestPartition) String() string { | |||
| percent := 100 - (float64(p.RemainingCapacity) / float64(p.TotalCapacity) * 100) | |||
| return fmt.Sprintf("[PART %d (%0.2f)]", p.Index, percent) | |||
| return fmt.Sprintf("[PART %d (%0.2fs)]", p.Index, p.Runtime.Seconds()) | |||
There was a problem hiding this comment.
Ah, was wondering why these all turned to 0.00s in the tests. They are just too small.
TAGraves
reviewed
Apr 21, 2025
tonywok
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting total runtime / partitions for bin capacity can lead to many scenarios where you have empty bins. This is not ideal for test partitioning because we want to distribute the tests across a specified number of workers as evenly as possible. Notably, we don't want to try to fill bins as full as possible leaving any empty.
Instead of bin packing, this problem more closely relates to load balancing. A simple "shortest queue first" approach works very well and ensures all partitions get tests (so long as there are more files than partitions). In this case, queue depth is the total runtime we've added so far.