-
Notifications
You must be signed in to change notification settings - Fork 4
Description
Like batch dim, spatial dims (with dynamic lengths), or static dims (named, or also unnamed).
Dim (earlier DimensionTag) in RETURNN. Directly use that, or wrap it somehow?
Should this (the batch dim) include beam information, or be separate from this?
Relevant for all layers which define some shape or dimension (e.g. Const, Variable).
Should this be enforced, i.e. no simple int allowed in n_out or so but always a Dim object?
And maybe better use out_dim instead of n_out (consistent with rwth-i6/returnn#597).
Edit: It was decided to make nn.Dim mandatory, and use out_dim instead of n_out.
Very related is this issue on RETURNN side on explicit dim tags: rwth-i6/returnn#597
Related is also whether we want unique dim tags? (#48, rwth-i6/returnn#632)
This issues covers multiple aspects:
- Use dim tags. Directly use RETURNN
Dim. We inherit all its logic on equality etc. We also haveFeatureDim,SpatialDimfrom RETURNN. - Dim tags (
Diminstances) are mandatory for any shape or size - Shape for all tensors is always available (via Make shape and dims available? #47)
- We have
Tensor.verify_out_shapefor easy verification - Solution for
in_dim == out_dim, square matrices, Design/Handling of dimension tags #17 (comment), Solution for ambiguous dim tags returnn#871 - Instead of
out_spatial_dimargument, the a new spatial dim gets returned. Seepool1dfor example. - Tensor shape annotations, moved to Tensor type annotations #97