Skip to content

Conversation

@albertz
Copy link
Member

@albertz albertz commented Nov 27, 2021

#597

Fix 2D/3D convolution/pooling (ConvLayer/PoolLayer) depends on order of axes (#594), when in_spatial_dims is used. There should be a follow-up maybe where this is required (for 2D/3D), with new behavior version.

Fix handling of unrelated dims, and also rec automatic optimization (#573).

@albertz
Copy link
Member Author

albertz commented Nov 28, 2021

I might also directly do the same for PoolLayer here.

@albertz albertz changed the title ConvLayer, in_dim, in_spatial_dims, out_dim, out_spatial_dims, WIP ConvLayer and PoolLayer, in_dim, in_spatial_dims, out_dim, out_spatial_dims Nov 29, 2021
@albertz albertz marked this pull request as ready for review November 29, 2021 10:34
@albertz albertz requested a review from a team as a code owner November 29, 2021 10:34
@albertz albertz merged commit 542c76c into master Nov 29, 2021
@albertz albertz deleted the albert-conv-dim-tags branch November 29, 2021 11:02
albertz added a commit that referenced this pull request Dec 1, 2021
Similar to #789.

Fix RecLayer for #573.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants