Skip to content

WindowLayer, window_dim and out_spatial_dim #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2021
Merged

WindowLayer, window_dim and out_spatial_dim #776

merged 1 commit into from
Nov 26, 2021

Conversation

@albertz
Copy link
Member

@albertz albertz commented Nov 26, 2021 •
edited
Loading

#597

Also fix #570.

out_spatial_dim should be consistent to what we use for ConvLayer and PoolLayer.
This is only relevant with padding=="valid" or stride!=1.

@albertz albertz requested a review from Zettelkasten November 26, 2021 14:01
@albertz albertz merged commit a984d0c into master Nov 26, 2021
@albertz albertz deleted the albert-window-dims branch November 26, 2021 14:31
@albertz albertz mentioned this pull request Nov 26, 2021
Closed
@Zettelkasten Zettelkasten mentioned this pull request Nov 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zettelkasten Zettelkasten Awaiting requested review from Zettelkasten

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WindowLayer with default window_left/window_right incorrect when inside loop vs moved out

2 participants

@albertz