CorpusObject: add parameters to init

[Icemole]

I find it much better to provide the parameters to an object via __init__ than to provide them by creating the object and explicitly setting the actual attribute. This helps for instance when I have to create a bunch of CorpusObjects in a list comprehension, which is similar to my use case.

If there was any explicit reason why these were not in the __init__ function please let me know.

[JackTemaki]

Is there anything that speaks against making this a dataclass instead?

[Icemole]

Is there anything that speaks against making this a dataclass instead?

That's also a good idea :) the only thing I'm worried about is inheriting from a non-dataclass like tk.Object. Otherwise, nothing at all!

[JackTemaki]

The inheritance can be removed, it plays no role at all as far as I can see. At least in i6_experiments there is not a single check for isinstance(tk.Object) and it does exactly nothing.

[Icemole]

The inheritance can be removed, it plays no role at all as far as I can see. At least in i6_experiments there is not a single check for isinstance(tk.Object) and it does exactly nothing.

Thanks for the feedback. I'll change it and leave it throughout the weekend, and if nobody complains we could merge this next week.

[michelwi]

I was worried this might change hashes, but apparently it does not.