update to Python 3.8 #409
Merged
update to Python 3.8 #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackTemaki
approved these changes
May 11, 2023
vieting
approved these changes
May 11, 2023
christophmluscher
approved these changes
May 11, 2023
Closed
This was referenced May 16, 2023
Atticus1806
added a commit
that referenced
this pull request
Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I also agree to bump the version to Python 3.8 as agreed in #408 i just tried it out now.
I am not 100% sure if this is already everything that needs to be changed, so please check aswell if I missed something.
BTW some tests already use Python 3.8