add assert for DelayedBase in parse_python #264
Conversation
There was a problem hiding this comment.
I think we should make conscious decisions which part of the code is run in the manager and may not access the values in Path/Variable objects and which part only runs in the worker and may resolve them.
And then we should start making use of check_is_worker also in the recipes.
And then we really should sort out the problem of get vs get_path and __str__ vs. __repr__
| @@ -235,6 +236,10 @@ def __parse_python(self, code, name=None): | |||
| if isinstance(code, str): | |||
| return code | |||
| if isinstance(code, DelayedBase): | |||
| assert self.hash_full_python_code is False, ( | |||
There was a problem hiding this comment.
I think this this is only necessary for tk.Variable. tk.Path should not change the hash over time.
So we could allow using Path objects for now.
On the other hand, we might want to change the representation of Path/Variable in the Manager and then it would break some hashes. So maybe disallowing all DelayedBase objects for now is a good idea.
Thinking of it.. tk.Path.get() in the hash will make the hash dependent of the full path.. :/
A quick rescue operation for #245