-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully implemented Invite Deep Link (Mixed Reality Lab 2021/2022) #397
Open
hmasara
wants to merge
52
commits into
develop
Choose a base branch
from
InviteDeepLinks/develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the DeepLinks and InviteLinks folder to the scripts, generated basic code skeletons for the DeepLinkManager and the InviteLinkGenerator
Invite link generation is currently handled in both InviteLinkManager and its own class, this is a duplicate and should be removed depending on final realization of class structure. A test button was added to the scene and should later be removed as well.
… working in bulid VIAProMa
…rapper DeepLinks | DeepLinkBootstrapper
DeepLink | Combined functions, added documentation, general cleanup
UI for invite link generation was added and integrated into existing UI architecture
…nvite Link Menu to Room Options and added Leave Room option there
…s not already there
updated to current version
Adjusted the URI in the invite link generator to be in line with the invite link handler
…s/VIAProMa into InviteDeepLinks/develop
…tion Room names can now only contain letters, numbers and underscores
Users can now share the invite link via mail. A mail template should open in the systems default mail client. Also added custom icons for "copy to clipboard" and "share via mail", created by myself to avoid licensing issues
added a text that gives feedback when you use the invite link share buttons
Invite deep links/share via mail
forgot to push last commit
…verything has chance to load, allows starting viaproma with deeplink and instantily joining session
DeepLink | DeepLink on start
TODO: Integrate config into DeepLinkBootstrapper. (Not sure if you can use variables instead of plain strings for: [DeepLink(scheme: "i5", path: "invite")] public void ReceiveDeepLink(DeepLinkArgs args)
Combine InviteLinkManager and InviteLinksHandler
…ndow DeepLink | Added ConfirmationWindow and expanded documentation
also removed artifacts of older xml config
Invite deep links/config file json
…nd roomwindow now closes when another room is joind via confirmation window
DeepLink | (hopefully) final fixes
added testscene
…kOnStart coroutine while PhotonNetwork not in Lobby
added !Network.InRoom abfrage to fix while(true) loop
changed test scene, fixed implementation
Already merged InviteDeepLinks/fix. The test scene is restructured and some implementation is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.