Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implemented Invite Deep Link (Mixed Reality Lab 2021/2022) #397

Open
wants to merge 52 commits into
base: develop
Choose a base branch
from

Conversation

hmasara
Copy link

@hmasara hmasara commented Jan 30, 2022

No description provided.

Felix755 and others added 30 commits December 28, 2021 13:36
Added the DeepLinks and InviteLinks folder to the scripts, generated basic code skeletons for the DeepLinkManager and the InviteLinkGenerator
Invite link generation is currently handled in both InviteLinkManager and its own class, this is a duplicate and should be removed depending on final realization of class structure.
A test button was added to the scene and should later be removed as well.
DeepLink | Combined functions, added documentation, general cleanup
UI for invite link generation was added and integrated into existing UI architecture
…nvite Link Menu to Room Options and added Leave Room option there
updated to current version
Adjusted the URI in the invite link generator to be in line with the invite link handler
…tion

Room names can now only contain letters, numbers and underscores
Users can now share the invite link via mail. A mail template should open in the systems default mail client.

Also added custom icons for "copy to clipboard" and "share via mail", created by myself to avoid licensing issues
added a text that gives feedback when you use the invite link share buttons
…verything has chance to load, allows starting viaproma with deeplink and instantily joining session
TODO: Integrate config into DeepLinkBootstrapper.

(Not sure if you can use variables instead of plain strings for:
[DeepLink(scheme: "i5", path: "invite")]
        public void ReceiveDeepLink(DeepLinkArgs args)
hmasara and others added 18 commits January 28, 2022 15:51
Combine InviteLinkManager and InviteLinksHandler
…ndow

DeepLink | Added ConfirmationWindow and expanded documentation
also removed artifacts of older xml config
…nd roomwindow now closes when another room is joind via confirmation window
…kOnStart

coroutine while PhotonNetwork not in Lobby
@hmasara hmasara added the enhancement New feature or request label Jan 30, 2022
@KritiaSthovania
Copy link
Member

Already merged InviteDeepLinks/fix. The test scene is restructured and some implementation is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants