Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Vanilla Vehicles Expanded/added Tier 3 support #394

Merged

Conversation

SokyranTheDragon
Copy link
Member

Anything from VVE Tier 3 that needed patching was included in the original vehicle mod (despite it not using it), so it acts as a framework. No need for separate patch for Tier 3 assembly, as it barely does anything (and nothing that needs patching).

Added temporary sync workers for Designation and DesignationManager, simplifying existing patch and one of the new ones.

Currently, one of the vehicles (Bunsen) causes desyncs when using its turrets. Currently investigating it, but seems like it may be an issue with Vanilla Expanded Framework. Not 100% sure yet.

Anything from VVE Tier 3 that needed patching was included in the original vehicle mod (despite it not using it), so it acts as a framework. No need for separate patch for Tier 3 assembly, as it barely does anything (and nothing that needs patching).

Added temporary sync workers for Designation and DesignationManager, simplifying existing patch and one of the new ones.
@SokyranTheDragon
Copy link
Member Author

Just to add to the last point:

  • The issue with Bunsen only happens when there's both a Workshop and a local copy of Vehicle Framework, while specifically running the Workshop one
  • The issue will likely happen with other mods though, so it's something that needs to be fixed anyway

@Zetrith
Copy link
Member

Zetrith commented Dec 27, 2023

I'll merge but the fact the new SyncWorker affects game state and isn't a pure data transform should be looked into.

@Zetrith Zetrith merged commit 008d68f into rwmt:master Dec 27, 2023
@SokyranTheDragon
Copy link
Member Author

I'll merge but the fact the new SyncWorker affects game state and isn't a pure data transform should be looked into.

Do you mean the one for Designation?

If you mean the DesignationOn/DesignationAt methods, then those use the def of the designation and thing/cell to retrieve the designation that should already exist. From what I can see, there should not be any change of game state there.

Besides those 2 methods I don't really see what else looks like it could change the game state here.

@Zetrith
Copy link
Member

Zetrith commented Dec 27, 2023

Ah, I was sure DesignationOn added a new one. All good then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants