-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for template codemods #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b293927
Add template test support
simonihmig c809c5d
Add bin-support for templates, updated test-support for full plugin r…
simonihmig 7995cbf
Add generator for template transforms and tests
simonihmig 9dba17c
Address PR feedback
simonihmig 6bf475a
Remove extra globby call in bin-support/runTemplateTransform
simonihmig 1902c28
Refactor transform type detection
simonihmig a21d5ca
Cleanup after PR feedback
simonihmig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
'use strict'; | ||
|
||
const { runInlineTest } = require('jscodeshift/dist/testUtils'); | ||
|
||
module.exports = function runJsTest(transform, input, expectedOutput) { | ||
return runInlineTest(transform, {}, input, expectedOutput); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
'use strict'; | ||
|
||
/* global expect */ | ||
|
||
const { transform, parse } = require('ember-template-recast'); | ||
|
||
module.exports = function runTemplateTest(plugin, { path: pluginPath, source }, expectedOutput) { | ||
const code = plugin( | ||
{ | ||
path: pluginPath, | ||
source, | ||
}, | ||
{ | ||
parse, | ||
visit(ast, callback) { | ||
const results = transform(ast, callback); | ||
return results && results.code; | ||
}, | ||
} | ||
); | ||
|
||
expect(code || '').toEqual(expectedOutput); | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
'use strict'; | ||
|
||
function transformDetails(options) { | ||
const { getTransformType, getTransformPath } = require('../transform-support'); | ||
const path = require('path'); | ||
|
||
let transformPath = getTransformPath(process.cwd(), options.name); | ||
let root = path.dirname(transformPath); | ||
let transformType = getTransformType(transformPath); | ||
|
||
return { | ||
name: options.name, | ||
root, | ||
transformPath, | ||
transformType, | ||
fixtureDir: path.join(root, '__testfixtures__/'), | ||
}; | ||
} | ||
|
||
module.exports = { | ||
transformDetails, | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that this is (or could be) basically the same as the jscodeshift one but we run a different function for actually testing (jscodeshift runs
runInlineTest
and this one runsrunTemplateTest
).I would prefer to refactor these together to avoid the duplication that exists right now, and to also ensure that both support the same feature set. At the moment, I think this file is missing the ability to test passing different command line options (that the template transform can access with
getOptions
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, done.