Use PYBIND11_DETAILED_ERROR_MESSAGES in smart_holder_type_casters.h (…

…follow-on to pybind#3913)
rwgk · May 5, 2022 · 72f51e1 · 72f51e1
1 parent 0157cb4
commit 72f51e1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/include/pybind11/detail/smart_holder_type_casters.h b/include/pybind11/detail/smart_holder_type_casters.h
@@ -722,9 +722,10 @@ struct smart_holder_type_caster : smart_holder_type_caster_load<T>,
                 if (copy_constructor) {
                     valueptr = copy_constructor(src);
                 } else {
-#if defined(NDEBUG)
+#if !defined(PYBIND11_DETAILED_ERROR_MESSAGES)
                     throw cast_error("return_value_policy = copy, but type is "
-                                     "non-copyable! (compile in debug mode for details)");
+                                     "non-copyable! (#define PYBIND11_DETAILED_ERROR_MESSAGES or "
+                                     "compile in debug mode for details)");
 #else
                     std::string type_name(tinfo->cpptype->name());
                     detail::clean_type_id(type_name);
@@ -741,10 +742,11 @@ struct smart_holder_type_caster : smart_holder_type_caster_load<T>,
                 } else if (copy_constructor) {
                     valueptr = copy_constructor(src);
                 } else {
-#if defined(NDEBUG)
+#if !defined(PYBIND11_DETAILED_ERROR_MESSAGES)
                     throw cast_error("return_value_policy = move, but type is neither "
                                      "movable nor copyable! "
-                                     "(compile in debug mode for details)");
+                                     "(#define PYBIND11_DETAILED_ERROR_MESSAGES or compile in "
+                                     "debug mode for details)");
 #else
                     std::string type_name(tinfo->cpptype->name());
                     detail::clean_type_id(type_name);