Board.Controller: fix warn messages

rwaldron · Oct 14, 2015 · 57c5ab5 · 57c5ab5
1 parent fd7fa13
commit 57c5ab5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/lib/board.js b/lib/board.js
@@ -996,7 +996,7 @@ Board.Controller = function(controller, options) {
           if (requirements.options[key].throws) {
             throw new Error(requirements.options[key].message);
           } else {
-            this.board.warn(requirements.options[key].message);
+            this.board.warn(this.constructor.name, requirements.options[key].message);
           }
         }
       }, this);

diff --git a/test/altimeter.js b/test/altimeter.js
@@ -133,7 +133,7 @@ exports["Altimeter -- MPL3115A2"] = {
   },
 
   missingRequirements: function(test) {
-    test.expect(2);
+    test.expect(3);
 
     new Altimeter({
       controller: "MPL3115A2",
@@ -143,7 +143,9 @@ exports["Altimeter -- MPL3115A2"] = {
     });
 
     test.equal(this.warn.callCount, 1);
-    test.equal(this.warn.getCall(0).args[0], "Missing `elevation` option. Without a specified base `elevation`, the altitude measurement will be inaccurate. Use whatismyelevation.com");
+    test.equal(this.warn.getCall(0).args[0], "Altimeter");
+
+    test.equal(this.warn.getCall(0).args[1], "Missing `elevation` option. Without a specified base `elevation`, the altitude measurement will be inaccurate. Use whatismyelevation.com");
 
     test.done();
   },

diff --git a/test/board.controller.js b/test/board.controller.js
@@ -86,7 +86,7 @@ exports["Board.Controller"] = {
   },
 
   requirementsMissingWarning: function(test) {
-    test.expect(2);
+    test.expect(4);
 
     var context = {
       board: this.board
@@ -98,6 +98,8 @@ exports["Board.Controller"] = {
 
     Board.Controller.call(context, controller, options);
 
+    test.equal(this.warn.getCall(0).args[0], "Object");
+    test.equal(this.warn.getCall(0).args[1], "message");
     test.equal(this.warn.callCount, 1);
     test.equal(this.odp.callCount, 1);