Additional Options #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te service files when not managed. Apps don't force reload of emperor as the emperor auto reloads the vassals.
| @@ -44,7 +44,6 @@ | |||
| group => $gid, | |||
| mode => '0644', | |||
| content => template($template), | |||
| require => Package[$::uwsgi::package_name], | |||
| notify => Service[$::uwsgi::service_name] | |||
There was a problem hiding this comment.
Is this notify not required? Is the directory monitored by the running service?
There was a problem hiding this comment.
Yes, that's correct. UWSGI in Emperor mode detects the modify time of the
vassals and reloads them automatically.
http://uwsgi-docs.readthedocs.org/en/latest/Emperor.html
On Sun, Apr 12, 2015 at 11:30 PM, Josh Smeaton notifications@github.com
wrote:
In manifests/app.pp
#11 (comment):@@ -44,7 +44,6 @@
group => $gid,
mode => '0644',
content => template($template),
require => Package[$::uwsgi::package_name],notify => Service[$::uwsgi::service_name]Is this notify not required? Is the directory monitored by the running
service?—
Reply to this email directly or view it on GitHub
https://github.com/Engage/puppet-uwsgi/pull/11/files#r28213853.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pidfile and socket so they can be specified. Made socket and log_dir optional for the emperor configuration. Added a check so if service files are not managed they won't be created.