perf(encode): tune string encoding thresholds for Node.js and browser #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimise fromString() thresholds based on benchmarking in today's standard runtimes: - Node.js (Buffer.from): change 64 to 24 chars - Browser (TextEncoder): change 64 to 200 chars Buffer.from has low overhead, so use it for shorter strings. TextEncoder has high call overhead (~10-20x slower than manual utf8ToBytes for short strings), so only use it for long strings. Node.js: +2-4% short string encode, +19-24% medium string encode Browser: +17-63% encode improvement across string-heavy workloads
|
🎉 This PR is included in version 4.5.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimise fromString() thresholds based on benchmarking in today's standard runtimes:
Buffer.from has low overhead, so use it for shorter strings. TextEncoder has high call overhead (~10-20x slower than manual utf8ToBytes for short strings), so only use it for long strings.
Node.js: +2-4% short string encode, +19-24% medium string encode
Browser: +17-63% encode improvement across string-heavy workloads