Repository navigation
feat(adr-001 #2): solve_on_change_sublinear — SubLinear delta-solve - #29
Merged
Merged
Conversation
Extends the change-driven solve API with a SubLinear sibling that
returns ONLY the closure entries as Vec<(usize, Precision)>, never
materialising the full n-vector. Generalises the inner primitive of
contrastive_solve_on_change_sublinear so non-contrastive callers
(Kalman updates, sensor-deduplicated controllers, change-tracked
HVAC loops) can use it directly.
Lands:
src/incremental.rs (+108 LOC)
solve_on_change_sublinear(matrix, prev, b_new, delta,
closure_depth, max_terms, tolerance)
Returns Vec<(row, x_new[row])> for every row in the bounded-depth
closure of delta.indices, computed via per-entry sublinear-Neumann.
Output sorted ascending by row index.
Empty delta short-circuits to empty result without touching the
matrix (the "no event, no work" path).
SolveOnChangeSublinearOp op marker — SubLinear class.
src/lib.rs
Re-exports solve_on_change_sublinear + SolveOnChangeSublinearOp.
docs/adr/ADR-001-complexity-as-architecture.md
Item #2 row updated to reflect phase-2 SubLinear path.
.github/complexity-baseline.txt
Adds SolveOnChangeSublinearOp (SubLinear).
Critical correctness test:
incremental::tests::sublinear_delta_solve_matches_full_solve_at_closure_entries
— on an 8×8 strict-DD chain, perturbing b[3] and running
solve_on_change_sublinear yields entries that match the full
NeumannSolver solve at every closure index within 1e-6.
Tests: 191 lib tests pass (was 188; +3 in incremental).
Co-Authored-By: claude-flow <ruv@ruv.net>
This was referenced May 19, 2026
ruvnet
added a commit
that referenced
this pull request
May 19, 2026
…trator The SubLinear orchestrator shipped in Rust (PR #29) had MCP preview primitives (coherenceScore, closureIndices, estimateComplexityClass) and a wire-callable witness (PR #52). But the orchestrator itself wasn't wire-callable — agents had to fall back to `solve` (which returns the full n-vector) instead of the closure-restricted entries the SubLinear path produces. This closes the gap with a pure-TS handler that chains: 1. closure_indices(matrix, delta.indices, closure_depth) 2. for each closure entry: truncated Neumann iteration restricted to the closure (mirrors src/entry.rs math) 3. return Vec<{row, value}> Lands in src/mcp/server.ts: - New `solveOnChangeSublinear` tool with x-complexity = SubLinear - Input schema: matrix, vector (b_new), delta_indices: number[], closure_depth (default 4), max_terms (default 32), tolerance (default 1e-8) - Dispatch case + handleSolveOnChangeSublinear method - Returns {entries: Array<{row, value}>, closure_size, max_terms, closure_depth, note} - Supports both dense and sparse-COO matrix formats Matches Rust solve_on_change_sublinear semantics exactly: - Early-exit when |delta_k[target]| < tolerance - Zero-diagonal in closure → InvalidParams - Empty closure → empty entries - note field warns when closure covers full matrix This completes the wire surface for the change-driven inner loop. Agents can now run the full pipeline over MCP: 1. coherenceScore (PR #53) — is the matrix solvable? 2. closureIndices (PR #54) — how wide is the work? 3. estimateComplexityClass (PRs #30, #42) — what class? 4. solveOnChangeSublinear (THIS PR) — actual SubLinear solve 5. verifySparseSolution (PR #52) — audit output All 5 tools are pure-TS. No Rust/WASM bridge required for any of them. Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends ADR-001 item #2 (change-driven solve) with a SubLinear sibling of `IncrementalSolver::solve_on_change` that returns only the closure entries as `Vec<(usize, Precision)>`, never materialising the full `n`-vector. Generalises the inner primitive of `contrastive_solve_on_change_sublinear` so non-contrastive callers (Kalman updates, sensor-deduplicated controllers, change-tracked HVAC loops) can use it directly.
What's new
Correctness gate
`incremental::tests::sublinear_delta_solve_matches_full_solve_at_closure_entries` — on an 8×8 strict-DD chain, perturbing `b[3]` and running `solve_on_change_sublinear` yields entries that match the full `NeumannSolver` solve at every closure index within `1e-6`.
Test plan
🤖 Generated with claude-flow