fix: use 'patterns' namespace consistently in hooks-tools (fixes #1136)#1183
Open
ripgtxgt wants to merge 1 commit intoruvnet:mainfrom
Open
fix: use 'patterns' namespace consistently in hooks-tools (fixes #1136)#1183ripgtxgt wants to merge 1 commit intoruvnet:mainfrom
ripgtxgt wants to merge 1 commit intoruvnet:mainfrom
Conversation
…et#1136) hooks-tools.ts used singular 'pattern' as the memory namespace in 4 locations while the rest of the codebase (workers/index.ts, reasoningbank, README examples) uses 'patterns' (plural). This caused a silent data loss bug: intelligence hooks stored patterns in namespace 'pattern', but memory_search and memory_list looked in 'patterns', making all stored pattern entries invisible to normal memory operations. Changed: - namespace: 'pattern' → namespace: 'patterns' - default || 'pattern' → default || 'patterns' - description string updated to reflect correct default
Author
|
Hi team 👋 Just checking in — any updates on this one? Happy to make adjustments if needed. Thanks! |
mixingchex
approved these changes
Feb 25, 2026
mixingchex
left a comment
There was a problem hiding this comment.
APPROVE — Reviewed via hive-mind swarm analysis.
All 4 changes are correct and necessary. The singular 'pattern' namespace caused silent data loss: patterns stored via intelligence hooks were invisible to memory search/list which uses 'patterns' (plural).
Grep confirms no remaining instances of the incorrect singular namespace.
Suggestions (non-blocking):
- Extract
'patterns'to a shared constant to prevent future drift - Add regression test for namespace consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1136
Problem
hooks-tools.tsused singular'pattern'as the memory namespace in 4 locations, while the rest of the codebase (workers/index.ts,reasoningbank/index.ts, README examples) consistently uses'patterns'(plural).This caused a silent data loss bug: intelligence hooks stored patterns in namespace
'pattern', butmemory_searchandmemory_listsearched in'patterns'— stored entries were invisible to normal memory operations.Fix
Changed all 4 occurrences in
hooks-tools.ts:namespace: 'pattern'→namespace: 'patterns'|| 'pattern'default →|| 'patterns'