fix: null-guard intelligence display to prevent TypeError crashes#1086
Open
SNooZyy2 wants to merge 1 commit intoruvnet:mainfrom
Open
fix: null-guard intelligence display to prevent TypeError crashes#1086SNooZyy2 wants to merge 1 commit intoruvnet:mainfrom
SNooZyy2 wants to merge 1 commit intoruvnet:mainfrom
Conversation
…shes The hooks intelligence command crashes with 'TypeError: Cannot read properties of undefined (reading toFixed)' when the MCP tool response is missing optional fields (learningTimeMs, adaptationTimeMs, avgQuality, expertsActive, routingAccuracy, loadBalance, searchSpeedup, memoryUsage, dimension, cacheHitRate, performance section). Added 15 null-guards using ?? operator across 5 display sections (SONA, MoE, HNSW, Embeddings, V3 Performance) to handle absent fields gracefully. Ref: ADR-015 Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hooks intelligencedisplay codeTypeError: Cannot read properties of undefined (reading 'toFixed')when MCP response fields are absentProblem
Running
claude-flow hooks intelligencecrashes immediately after printing the SONA header because the MCP tool handler (hooks_intelligence) does not include computed fields likelearningTimeMs,adaptationTimeMs,avgQualityetc. in its response. The display code calls.toFixed()on undefined values.Fix
Uses
??(nullish coalescing) to provide safe defaults:?? 0for numeric fields?? 'N/A'for string fields?.for optional parent objects (result.performance?.flashAttention)Test plan
claude-flow hooks intelligence— should display full dashboard without crash (exit 0)claude-flow hooks intelligence --format json— should output valid JSONGenerated with claude-flow