Repository navigation
fix(relay): preserve complete UDP datagrams - #2228
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSI UDP relay promises byte-for-byte forwarding but its 2048-byte receive buffer truncates larger datagrams, including the 2068-byte maximum ADR018 antenna/subcarrier shape. Its truthiness check also drops empty UDP payloads. Receive complete datagrams and distinguish an empty payload from the timeout sentinel, preserving the transparent relay contract.
The actual public Python CLI loopback producer reproduces both defects; fixed tests compare complete packet bytes, empty payloads and ordinary small datagrams. Three focused tests and all eight local harness gates pass (196 full tests pass, one skipped; security 91 pass, one skipped). Independent exact-commit loopback replay passes all three tests. Includes ADR413; manifest refresh is unchanged because production is outside the npm package. Owned loopback transport evidence does not establish physical RF fidelity. Hosted checks may require maintainer approval.