Skip to content

Conversation

@utrack
Copy link

@utrack utrack commented May 24, 2025

LLM-generated, human-tested :)

This commit makes it work in zsh and ksh, and bash works as it did before. I didn't test any other shells, but that's already better :)

@rusty-snake
Copy link
Owner

Ok, but why do we need this?

@utrack
Copy link
Author

utrack commented May 24, 2025

The current version silently exits if the shell doesn't have $BASH_VERSION (i.e. not bash, I guess).

On zsh, source /etc/profile.d/zz-firecfg.py.sh (assuming Arch AUR package is installed) does nothing - the paths don't change.

@rusty-snake
Copy link
Owner

Ahh yeah right, there is also an entrypoint via /etc/profile.d. And some user break things by changing login shell.

@utrack
Copy link
Author

utrack commented May 24, 2025

Well yeah, that and the fact that 'sh' is a valid login shell too...
As far as I see, every other profile script on my machine is in portable sh syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants