Search for tools in download_prebuilt #876
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike other tools, wasm-opt doesn't have an option to `cargo install`, so the `which` check in `download_prebuilt_or_cargo_install` wasn't applicable. It makes more sense to move such check to the more generic function `download_prebuilt`, in which case it's going to work for all tools in the same way. Additionally, if the found version doesn't match the expected one, but user has specified `--mode=no-install`, try to use the tool anyway - most likely user knows what they're doing, and the version is backward-compatible, but if not, worst case the tool will error out on invalid params. Fixes rustwasm#869.
|
Is there any reason why this is not getting merged? |
|
@ctron the reason it's not getting merged is that this tool has suffered a lag in maintenance and currently our CI is not functioning. I'm hoping to sort this today which should help with merging things. I apologize for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike other tools, wasm-opt doesn't have an option to
cargo install, so thewhichcheck indownload_prebuilt_or_cargo_installwasn't applicable.It makes more sense to move such check to the more generic function
download_prebuilt, in which case it's going to work for all tools in the same way.Additionally, if the found version doesn't match the expected one, but user has specified
--mode=no-install, try to use the tool anyway - most likely user knows what they're doing, and the version is backward-compatible, but if not, worst case the tool will error out on invalid params.Fixes #869.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨