Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wasm-dis #750

Closed
wants to merge 4 commits into from
Closed

Support wasm-dis #750

wants to merge 4 commits into from

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Dec 12, 2019

Closes #748

@ashleygwilliams ashleygwilliams added the work in progress do not merge! label Jan 15, 2020
@ashleygwilliams
Copy link
Member

hey @csmoe ! this is marked as a draft- definitely a feature i'd love to see, anything i can do to help move this forward?

@csmoe
Copy link
Member Author

csmoe commented Feb 14, 2020

@ashleygwilliams sorry for the delay, more commits soon.

@csmoe csmoe marked this pull request as ready for review February 22, 2020 06:45
@csmoe
Copy link
Member Author

csmoe commented Feb 24, 2020

@ashleygwilliams review notes:

  1. this PR contains a refactoring of third-party tools, making it easier to introduce more tools in the future.
  2. wasm-dis will be exec'd after opt if wasm-opt is enabled.

image

@csmoe csmoe force-pushed the wat branch 2 times, most recently from 4e6d586 to 8393d50 Compare March 31, 2020 03:24
@csmoe

This comment has been minimized.

Sign in to view
@csmoe csmoe mentioned this pull request Mar 31, 2020
Open
@csmoe
Copy link
Member Author

csmoe commented Dec 1, 2020 •
edited
Loading

@ashleygwilliams @Pauan sorry for disconnection, would you mind having a review? thanks :)

@Pauan
Copy link
Contributor

Pauan commented Dec 1, 2020

@csmoe Sorry, I don't contribute to Rust anymore. Ashley is trying to find a maintainer for wasm-pack:

#914
#928

@csmoe
Copy link
Member Author

csmoe commented Mar 18, 2021

It has been a while without response, closing for not blocking the progress of #820.

@csmoe csmoe closed this Mar 18, 2021
@raphamorim
Copy link

raphamorim commented Jul 28, 2022 •
edited
Loading

Hey there @csmoe @ashleygwilliams @drager this change would be nice to have. Let me know if I could take the work on it 👍

@csmoe
Copy link
Member Author

csmoe commented Jul 30, 2022

@raphamorim yep 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
work in progress do not merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add compile crate to WAT
4 participants
@csmoe @ashleygwilliams @Pauan @raphamorim