-
Notifications
You must be signed in to change notification settings - Fork 444
[WIP] Introduce an All
target for outputting all supported module types by wasm-pack
#705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
torch2424
wants to merge
10
commits into
rustwasm:master
Choose a base branch
from
torch2424:target-all
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4ef0e53
Started the AllPackage
torch2424 98207b5
Got stuff building, but found a wasm-pack bug
torch2424 90b9dd1
Added some more test code but nothing is being called? I' also super β¦
torch2424 15dd900
Got logging working
torch2424 80f2134
Got the package json working correctly
torch2424 18c6bec
Got all generating almost everything
torch2424 ebb113b
Fixed node output for wasm-bindgen
torch2424 a099713
Got the renaming working. Simply need to fix up files in package json
torch2424 6033ee5
Fiinshed up the wasm-pack PR
torch2424 7181604
Ran cargo fmt
torch2424 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given @Pauan's comment and the likelihood that folks will want to customize the types of targets they want... i could imagine that instead of an
All
type, you have a new type that is aTargets: Vec<Target>
- and for just Node, the Targets would byVec<Nodejs>
, and all would beVec<Web, Nodejs, NoModules>