#649 without the test update commit #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ashleygwilliams merged 1 commit into master from rhysd-fix-side-effects

Jul 17, 2019

Member

ashleygwilliams commented Jul 16, 2019 •

edited

Loading

#649 without the test update commit because the test failure seems spurious

ashleygwilliams mentioned this pull request

Fix sideEffects value in generated package.json should be boolean #649

Closed

3 tasks

ashleygwilliams added this to the 0.9.0 milestone

ashleygwilliams force-pushed the rhysd-fix-side-effects branch from e58d2f4 to e4890c4 Compare

July 16, 2019 19:03

Member Author

ashleygwilliams commented Jul 16, 2019

need to make sideEffects optional and then this can be good to go
the error on this is hilarious right now if anyone wants to check it out https://travis-ci.com/rustwasm/wasm-pack/jobs/216625948#L454


          Fix sideEffects value in generated package.json should be empty

5a58e8e

ashleygwilliams force-pushed the rhysd-fix-side-effects branch from e4890c4 to 5a58e8e Compare

July 16, 2019 22:58

ashleygwilliams merged commit 9a2722d into master

ashleygwilliams deleted the rhysd-fix-side-effects branch

July 17, 2019 14:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet