Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#640 minus changelog #678

Merged
merged 1 commit into from
Jul 16, 2019
Merged

#640 minus changelog #678

merged 1 commit into from
Jul 16, 2019

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Jul 16, 2019 •
edited
Loading

#640 minus the changelog

@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jul 16, 2019
@ibaryshnikov
Copy link
Member

@ashleygwilliams what do you think about updating this line?
https://github.com/rustwasm/wasm-pack/blob/master/src/bindgen.rs#L45
which is currently Target::Bundler => "--browser",

@ashleygwilliams
Copy link
Member Author

CI failure on debug assertions is not related to this PR

@ashleygwilliams ashleygwilliams merged commit 1be5e91 into master Jul 16, 2019
@ashleygwilliams ashleygwilliams deleted the ibaryshnikov-master branch July 16, 2019 17:57
@ashleygwilliams
Copy link
Member Author

whoops @ibaryshnikov totally missed your comment. i'll get it in!

This was referenced Jul 16, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleygwilliams @ibaryshnikov