Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rustfmt install snippet in pull request template #664

Merged
merged 1 commit into from
Jun 17, 2019
Merged

update rustfmt install snippet in pull request template #664

merged 1 commit into from
Jun 17, 2019

Conversation

data-pup
Copy link
Member

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Fixes #639. Updates rustfmt install instructions in PR template 😸

@ashleygwilliams ashleygwilliams modified the milestones: 0.10.0, 0.9.0 Jun 17, 2019
@ashleygwilliams
Copy link
Member

thank you so much!

@ashleygwilliams ashleygwilliams merged commit f4779be into rustwasm:master Jun 17, 2019
@data-pup data-pup deleted the update-pr-template branch June 17, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
changelog - maintenance
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Update template for pull requests
2 participants
@data-pup @ashleygwilliams