Windows fixes #489
Merged
Windows fixes #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`child::run` overrides the stdout config, so is misleading to to set it differently beforehand. `child::run` uses `spawn()`, which inherits stdin by default. So, no need to set stdin to default beforehand, particularly when the spawned program is non-interactive.
Issue rustwasm#277 - Affects running login, pack, and publish on Windows. `Command::new("npm")` launched `npm` with quotes, `"npm"`, causing a run-time error on Windows. Now, `Command::new` is wrapped by `child::new_command(program: &str)`. This prepends `cmd /c` to the program name if `cfg!(windows)`. See rustc: #42436, #42791, #44542
ashleygwilliams
approved these changes
Jan 13, 2019
There was a problem hiding this comment.
this looks good to me! i'm going to have @steveklabnik also test locally, just to be sure everything works (i trust u of course, but it's always good to test twice <3 )
|
@steveklabnik could you test this locally on your Windows set up? |
|
|
|
(also made @steveklabnik actually run the commands on Windows as i sadly don't trust our tests for this- and success! thanks again @danwilhelm - this work is very much appreciated!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #277 - Affects running login, pack, and publish on Windows.
Wraps
Command::newbychild::new_command(program: &str). This prependscmd /cto the program name ifcfg!(windows). See rustc: #42436, #42791, #44542See commits for more details. Tested build/login/pack/publish on the latest stable Windows, Mac, and Ubuntu.
rustfmtinstalledcargo fmton the code base before submitting