Remove branch: master from AppVeyor deploy
#301
Conversation
It looks like Windows releases aren't getting build for wasm-pack tags unfortunately and taking a look at the [last logs][logs] it looks like the reason is that the `master` branch is required. I'm not actually entirely sure what's required here but by removing this it's closer to `wasm-bindgen`'s configuration which I think is working! [logs]: https://ci.appveyor.com/project/ashleygwilliams/wasm-pack-071k0/build/1.0.72
This is required later for deployment due to copying over `target/release/wasm-pack.exe`, so let's make sure that it's available when we're copying things over!
|
Er actually realized that the deploy wasn't actually getting its release artifacts built as well so pushed up a commit for that as well as making the binaries a bit more compatible with more windows versions. |
.appveyor.yml
Outdated
| @@ -8,7 +12,7 @@ install: | |||
| build: false | |||
|
|
|||
| test_script: | |||
| - cargo test --locked -- --test-threads 1 | |||
| - cargo test --release --locked -- --test-threads 1 | |||
There was a problem hiding this comment.
i think we can also remove the test-threads req here now
There was a problem hiding this comment.
should we add --release to .travis.yml as well? https://github.com/rustwasm/wasm-pack/blob/master/.travis.yml#L39
There was a problem hiding this comment.
Nah that's fine to be non-release as it's not producing a final binary. AppVeyor right now doesn't have separate jobs (like Travis does) for building releases and testing, and from my experience at least that tends to work out alright.
In that sense this is just needed here for AppVeyor because we're both testing a binary and publishing it, whereas Travis either publishes it or tests it. Testing without --release is generally preferred for Travis because it gets you results more quickly
There was a problem hiding this comment.
Also certainly, can remove --test-threads!
| @@ -1,3 +1,7 @@ | |||
| environment: | |||
| global: | |||
| RUSTFLAGS: -C target-feature=+crt-static | |||
Pass the `-C target-feature=+crt-static` feature on AppVeyor to ensure that binaries produced on Windows have as few dynamic dependencies as possible, making them more portable to run on more Windows machines.
alexcrichton
force-pushed
the
tweak-appveyor
branch
from
6f9def5
to
d6146b2
Compare
|
🎉 |
fixes #147
It looks like Windows releases aren't getting build for wasm-pack tags
unfortunately and taking a look at the last logs it looks like the
reason is that the
masterbranch is required. I'm not actually entirely surewhat's required here but by removing this it's closer to
wasm-bindgen'sconfiguration which I think is working!