Provide single quote separators around missing Cargo.toml fields to improve readability #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prove readability
twilco
changed the title
ashleygwilliams
approved these changes
Sep 11, 2018
|
Heh, @ashleygwilliams beat me to it :-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, the CLI output would read:
[4/8] 📂 Creating a pkg directory...
⚠️ [WARN]: Field description is missing from Cargo.toml. It is not necessary, but recommended
⚠️ [WARN]: Field repository is missing from Cargo.toml. It is not necessary, but recommended
⚠️ [WARN]: Field license is missing from Cargo.toml. It is not necessary, but recommended
[5/8] 📝 Writing a package.json...
Which confused me at first glance, as I read literally that a field description was missing. After this change, the output would be:
[4/8] 📂 Creating a pkg directory...
⚠️ [WARN]: Field 'description' is missing from Cargo.toml. It is not necessary, but recommended
⚠️ [WARN]: Field 'repository' is missing from Cargo.toml. It is not necessary, but recommended
⚠️ [WARN]: Field 'license' is missing from Cargo.toml. It is not necessary, but recommended
[5/8] 📝 Writing a package.json...
Which I feel reads a bit better :)