Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value parser for Option<PathBuf> #1307

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

Myriad-Dreamin
Copy link
Contributor

@Myriad-Dreamin Myriad-Dreamin commented Jun 21, 2023

A value parser for OsString cannot parse a command line argument for Option<PathBuf>, which let it failed to specify paths for pack, publish and test commands, which was introduced by 73e059f.

close #1304.

$ ./target/debug/wasm-pack publish abc
thread 'main' panicked at 'Mismatch between definition and access of `path`. Could not downcast to std::path::PathBuf, need to downcast to std::ffi::os_str::OsString
', src/command/mod.rs:74:15

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on setting chromedriver option.
2 participants