Add linux/arm64 to release workflow #1065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! Looking forward for a |
|
Couldn't we use |
|
I'm using macos monterey, I try to do step by step on above, and it doesn't work. I'm really not clearly step: "You ran cargo fmt on the code base before submitting". Could anyone explain it for me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build and release
aarch64-unknown-linux-musltarget. Solves first part of #1064.With this change we can easily add more targets in the future. Once GH updates
macos-latestto using MacOS 11, we can addaarch64-apple-darwin.You can see that the release workflow succeeds here: https://github.com/nacardin/wasm-pack/actions/runs/1291954371
rustfmtinstalledcargo fmton the code base before submitting