Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targeting Deno #879

Closed
eliorivero opened this issue Jul 19, 2020 · 2 comments
Closed

Targeting Deno #879

eliorivero opened this issue Jul 19, 2020 · 2 comments

Comments

@eliorivero
Copy link

eliorivero commented Jul 19, 2020

🐛 Bug description

I saw this https://rustwasm.github.io/docs/wasm-bindgen/reference/deployment.html#deno mentioning that you could pass --target deno and build to Deno. I tried:

wasm-pack build --target deno

and got

error: Invalid value for '--target <target>': Unknown target: deno

🤔 Expected Behavior

A package suitable to be used in Deno should've been created.

👟 Steps to reproduce

cargo new rust-deno-test --lib
cd rust-deno-test

Edit src/lib.rs and replace its contents with:

use wasm_bindgen::prelude::*;

#[wasm_bindgen]
pub fn factorial( x: u64 ) -> u64 {
    match x {
        0 | 1 => 1,
        _ => x * factorial( x - 1 ),
    }
}

Edit Cargo.toml and merge:

[dependencies]
wasm-bindgen = "0.2.65"

[lib]
crate-type =["cdylib"]

Then run

wasm-pack build --target deno

🌍 Your environment

wasm-pack version: 0.9.1
rustc version: 1.44.1

Notes

The tool ssvmup can successfully convert the same code to a package that's usable by Deno, with a similar command ssvmup build --target deno.

@stevebest
Copy link

wasm-bingen seems to have recently gained support for deno target, but the option is not forwarded to it by wasm-pack.

I have quickly hacked a patch which seems to work at first glance. It does a bit more than required, even: for example, it generates a package.json, which Deno doesn't use.

I could work on a PR, but consider the fact that I only had a proper look at Deno yesterday.

@drager
Copy link
Member

drager commented Mar 19, 2023

Fixed in v0.11.0.

@drager drager closed this as completed Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants