Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide version to init.sh #779

Open
dsherret opened this issue Feb 1, 2020 · 3 comments
Open

Ability to provide version to init.sh #779

dsherret opened this issue Feb 1, 2020 · 3 comments

Comments

@dsherret
Copy link

dsherret commented Feb 1, 2020

💡 Feature description

My CI started doing this error today. Seems to be related to the new release since when I re-run an old build that passed yesterday it now fails.

I'm thinking for scenarios like this it might be useful to be able to provide a version to init.sh so people can peg their builds to a specific version rather than always getting the latest. It would also allow me to easily test that the new version is indeed the problem and not something that the CI provider changed.

💻 Basic example

# but parameterize this with 0.8.1...
curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh -s -- -f
@dsherret
Copy link
Author

dsherret commented Feb 1, 2020

That said, perhaps I should just be using cargo install wasm-pack. I will look into this more tomorrow.

@Pauan
Copy link
Contributor

Pauan commented Feb 1, 2020

(As another alternative, you can use the npm package and specify a precise version)

@ashleygwilliams ashleygwilliams added bug Something isn't working needs investigation labels Feb 1, 2020
@ashleygwilliams ashleygwilliams self-assigned this Feb 1, 2020
@dsherret
Copy link
Author

dsherret commented Feb 1, 2020

Thanks @Pauan! I didn't know about that.

I changed all my npm packages to reference the 8.1 npm package as a dev dependency and now it's working, so my problem is indeed with the latest version (related to wasm-opt).

I think the feature I was inquiring about here is not necessary and feel like instead it should be recommend that people use the npm package if they're using this with an npm package (maybe it does say that somewhere and I'm just missing it).

This issue should probably be closed and I will open a separate issue with my bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants