Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-opt not working on latest master #696

Closed
torch2424 opened this issue Jul 30, 2019 · 7 comments
Closed

wasm-opt not working on latest master #696

torch2424 opened this issue Jul 30, 2019 · 7 comments
Labels
bug Something isn't working waiting on response
Milestone

Comments

@torch2424
Copy link

torch2424 commented Jul 30, 2019

relates to #625

🐛 Bug description

The installed wasm-opt with wasm-pack on the current master isn't working an exits with signal 6:

Screenshot from 2019-07-29 07-36-12

🤔 Expected Behavior

wasm-opt should run, optimize the wasm file, and not error/stop building the package with wasm-pack

👟 Steps to reproduce

  1. Clone the repo
  2. cargo run build [path to your rust wasm module]

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: current master
rustc version: 1.34.1

cc @alexcrichton 😄

@alexcrichton
Copy link
Contributor

What OS are you running on? (e.g. Ubuntu/Debian/etc)

Additionally can you upload the wasm file which causes this segfault?

@torch2424
Copy link
Author

@alexcrichton

What OS are you running on? (e.g. Ubuntu/Debian/etc)

Oops totally forgot that 😂

Screenshot from 2019-07-31 01-11-56

pop_OS! is a derivative of Ubuntu 😄

Additionally can you upload the wasm file which causes this segfault?

So here is the terminal output:

Screenshot from 2019-07-31 01-14-41

So from that, I assume I need to get the pkg/wasmboypluginhqx_bg.wasm. Which you can download here.

Let me know if that helps! 😄

@alexcrichton
Copy link
Contributor

Ok using the release_78 binaries locally myself I can get -O3 to segfault when running over that wasm file. Additionally using the latest release_87 it segfaults. I've opened WebAssembly/binaryen#2273 as an upstream issue.

@torch2424
Copy link
Author

@alexcrichton Awesome! Thank you very much! 😄 Stoked I can help!

@ashleygwilliams ashleygwilliams added bug Something isn't working blocked labels Aug 6, 2019
@anp
Copy link

anp commented Sep 14, 2019

Now that version_89 is released, would it make sense to attempt updating the wasm-opt installer version?

EDIT: That version doesn't seem to solve the problem for me, unfortunately.

@ashleygwilliams
Copy link
Member

@anp i know this is a super late message but did you happen to try version 90? want to release wasmpack1.9.0 soon and do not want to break all linux users

@ashleygwilliams
Copy link
Member

i'm going to close this because i do believe that today's release will fix it. if it does not- please open a new issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting on response
Projects
None yet
Development

No branches or pull requests

4 participants