Skip to content

wasm-pack does not rate limit its version check if the request fails #653

Closed
@sgrif

Description

@sgrif

🐛 Bug description

When wasm-pack looks for a more recent version, it limits this check to once every 24 hours normally. When the request fails, however, it will try again on the next run. Based on our logs, there are folks who are running wasm-pack in a loop on their home network. Since all of these version checks are currently being blocked (#651), this has resulted in a substantial enough spike in 4xx traffic to be noticeable on our graphs.

If the reason this failed is because crates.io has gone down due to being overloaded, this can amplify the problem. There should be some form of exponential backoff in the case of an error.

🤔 Expected Behavior

wasm-pack should not immediately retry its version check if the last one failed.

Metadata

Metadata

Assignees

Labels

PR attachedthere's a PR open for this issuebugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions