Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional cargo arguments (wasm-pack test) #538

Closed
zrzka opened this issue Feb 5, 2019 · 1 comment
Closed

Add support for additional cargo arguments (wasm-pack test) #538

zrzka opened this issue Feb 5, 2019 · 1 comment

Comments

@zrzka
Copy link

zrzka commented Feb 5, 2019

💡 Feature description

wasm-pack 0.6 supports additional cargo arguments, but for the build only, not test.

💻 Basic example

I can do:

bash-3.2$ wasm-pack build --target nodejs  --out-dir pkg -- --features disable-wasm-bindings

  [1/10] 🦀  Checking `rustc` version...
  [2/10] 🔧  Checking crate configuration...
  [3/10] 🎯  Adding WASM target...

But I can't do:

bash-3.2$ wasm-pack test --chrome --firefox --headless -- --features disable-wasm-bindings
error: Found argument 'disable-wasm-bindings' which wasn't expected, or isn't valid in this context

USAGE:
    wasm-pack test --chrome --firefox --headless

For more information try --help
bash-3.2$
@fitzgen
Copy link
Member

fitzgen commented Feb 5, 2019

Good news! This was implemented in #530. But its only on master -- will be part of the 0.6.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants