Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass arguments through to cargo test #530

Merged
merged 6 commits into from
Jan 28, 2019
Merged

Pass arguments through to cargo test #530

merged 6 commits into from
Jan 28, 2019

Conversation

chinedufn
Copy link
Contributor

Closes #525

chinedufn
chinedufn commented Jan 27, 2019
View reviewed changes
Copy link
Contributor Author

@chinedufn chinedufn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let some PR notes - ready for review!

src/command/test.rs Outdated Show resolved Hide resolved
@chinedufn
Copy link
Contributor Author

Mmmm I see the lockfile is used to know what version of wasm-bindgen to download... Cool adding that stuff back

csmoe
csmoe reviewed Jan 28, 2019
View reviewed changes
src/test/mod.rs Outdated Show resolved Hide resolved
@csmoe @chinedufn
Apply suggestions from code review
1e4ae14 
Thanks!

Co-Authored-By: chinedufn <frankie.nwafili@gmail.com>
ashleygwilliams
ashleygwilliams approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great to me! thank you! waiting on merge for @fitzgen's review

@ashleygwilliams ashleygwilliams added this to the 0.6.1 milestone Jan 28, 2019
fitzgen
fitzgen approved these changes Jan 28, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a bunch @chinedufn :)

docs/src/commands/test.md
@@ -0,0 +1,56 @@
# wasm-pack test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@fitzgen fitzgen merged commit 4c4272c into rustwasm:master Jan 28, 2019
@chinedufn chinedufn deleted the pass-through branch January 28, 2019 18:23
@fitzgen fitzgen mentioned this pull request Feb 5, 2019
Closed
@fitzgen fitzgen added the TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csmoe csmoe csmoe left review comments

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
changelog - feature TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chinedufn @fitzgen @ashleygwilliams @csmoe