-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error don't panic during wasm-bindgen binary installation for wasm-pack test
#503
Comments
It seems like this is the first relevant frame of the stack trace:
|
I belive that this is the assertion failing: /// Returns the path to the binary `name` within this download
pub fn binary(&self, name: &str) -> PathBuf {
let ret = self
.root
.join(name)
.with_extension(env::consts::EXE_EXTENSION);
assert!(ret.exists(), "binary {} doesn't exist", ret.display());
return ret;
} |
|
Hm ok, now that wasm-bindgen=0.2.32 has tarballs published, this panic went away... |
wasm-pack test
wasm-pack test
@fitzgen i think there's a small moment where the binaries aren't available iirc from a convo with @alexcrichton when we first moved to binary install method. i strongly agree we should error instead of panic tho, but i think that small moment on unavailability might be inevitable? |
Right, there is a duration between publishing and when tarballs are ready. But our fallback to |
yeah, looks like that is not happening and we should definitely fix,beyond just erroring instead of paniking. |
likely related: #497 |
stdout
Panic Report
The text was updated successfully, but these errors were encountered: