Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move binary install crate to its own repo? #500

Closed
ashleygwilliams opened this issue Jan 16, 2019 · 6 comments · Fixed by #600
Closed

move binary install crate to its own repo? #500

ashleygwilliams opened this issue Jan 16, 2019 · 6 comments · Fixed by #600
Labels
current release current todo items refactor
Milestone

Comments

@ashleygwilliams
Copy link
Member

ashleygwilliams commented Jan 16, 2019

the "workspace" setup for binary install atm is... not ideal. i think i would, once we feel it's sufficiently decoupled from active dev in wasm-pack (which may be now since the global cache work landed?) to move it to its own repo in the org, completely working around the confusion around workspaces. this will also allow us to do release notes, etc, with no added noise to this repo. do folks have thoughts?

cc @drager

@ashleygwilliams ashleygwilliams added question Further information is requested refactor labels Jan 16, 2019
@ashleygwilliams ashleygwilliams added this to the 0.7.0 milestone Jan 16, 2019
@ashleygwilliams ashleygwilliams changed the title move binary install crate to it's own repo? move binary install crate to its own repo? Jan 16, 2019
@drager
Copy link
Member

drager commented Jan 16, 2019

I agree that it would be a good idea to move it to it's own repo, since it is no longer coupled to wasm-pack and could potentially be used by other projects as well.

@ashleygwilliams
Copy link
Member Author

looks like we're dealing with some issues with binary install panicking so we shouldn't move too quickly on this- but once we've done that moving it to it's own repo and giving it some unit tests seems like a good idea.

@drager
Copy link
Member

drager commented Mar 9, 2019

@ashleygwilliams How's the status here? Is the panic resolved? If it's solved I think we could move this now, since #517 is merged.

@ashleygwilliams ashleygwilliams added current release current todo items PR welcome and removed question Further information is requested labels Mar 14, 2019
@ashleygwilliams
Copy link
Member Author

@drager i think we can do this now! i'll make a repo and add you as a contrib! (assuming you want to take this on?)

@drager
Copy link
Member

drager commented Mar 14, 2019

@ashleygwilliams That sounds good!

@drager
Copy link
Member

drager commented Mar 23, 2019

New repository for binary-install can be found here: https://github.com/rustwasm/binary-install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current release current todo items refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants